Skip to content

Conversation

@chungjac
Copy link
Contributor

@chungjac chungjac commented Feb 4, 2025

Problem

  • valid language tests are flaky, specifically the "before each" hook is failing in the CI for valid language

Solution

  • skip valid language tests for now

These changes will be helpful for when we come back to this issue:

  • use closeAllEditors function in existing testUtils file
  • retries for setting up and opening text file

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested a review from a team as a code owner February 4, 2025 19:23
@chungjac chungjac changed the title add waitUntil in beforeEach for valid languages test(amazonq): add waitUntil in beforeEach for valid languages Feb 4, 2025
@chungjac chungjac closed this Feb 4, 2025
@chungjac chungjac reopened this Feb 4, 2025
@chungjac chungjac marked this pull request as draft February 4, 2025 19:26
@chungjac
Copy link
Contributor Author

chungjac commented Feb 5, 2025

/runintegrationTests

@chungjac chungjac changed the title test(amazonq): add waitUntil in beforeEach for valid languages test(amazonq): skip valid language tests Feb 5, 2025
@chungjac chungjac marked this pull request as ready for review February 5, 2025 19:47
@justinmk3 justinmk3 merged commit af77b1f into aws:master Feb 5, 2025
31 of 32 checks passed
KevinDing1 pushed a commit to KevinDing1/aws-toolkit-vscode that referenced this pull request Feb 6, 2025
## Problem
- valid language tests are flaky, specifically the "before each" hook is
failing in the CI for valid language

## Solution
- skip valid language tests for now

These changes will be helpful for when we come back to this issue:
- use closeAllEditors function in existing testUtils file
- retries for setting up and opening text file
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
## Problem
- valid language tests are flaky, specifically the "before each" hook is
failing in the CI for valid language

## Solution
- skip valid language tests for now

These changes will be helpful for when we come back to this issue:
- use closeAllEditors function in existing testUtils file
- retries for setting up and opening text file
@chungjac chungjac deleted the waitUntil branch February 21, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants